Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Enables sushy-tool image multiarch builds #616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Enables sushy-tool image multiarch builds #616

wants to merge 1 commit into from

Conversation

e-minguez
Copy link
Contributor

@e-minguez e-minguez commented Feb 3, 2025 •
edited
Loading

What this PR does / why we need it:
This (hopefully) enables multiarch builds on the sushy-tools container image.

Which issue(s) this PR fixes:
Fixes #615

Also, see metal3-io/project-infra#960 as required for this to work.

@metal3-io-bot
Copy link
Contributor

Hi @e-minguez. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2025
@e-minguez e-minguez force-pushed the multiplatform-sushy-tools branch from c51a202 to 72ce9f6 Compare February 3, 2025 16:41
Rozzii
Rozzii reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/cc @elfosardo @dtantsur

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2025
tuminoid
tuminoid reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Let's also not take this in before project-infra PR is sorted out to avoid changing the inputs here if we do some modifications there.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@e-minguez e-minguez force-pushed the multiplatform-sushy-tools branch from 72ce9f6 to a1fe613 Compare February 4, 2025 10:20
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@e-minguez
Copy link
Contributor Author

Pushed a README note as per #615 (comment)

@dtantsur
Copy link
Member

dtantsur commented Feb 6, 2025

Markdownlint seems to dislike something. I cannot find the jobs logs but you can run it locally with ./hack/markdownlint.sh

@e-minguez
Copy link
Contributor Author 

metal3-ironic-image on  multiplatform-sushy-tools
❯ hack/markdownlint.sh
+ IS_CONTAINER=false
+ CONTAINER_RUNTIME=podman
+ '[' false '!=' false ']'
+ podman run --rm --env IS_CONTAINER=TRUE --volume /Users/eminguez/git/metal3-ironic-image:/workdir:ro,z --entrypoint sh --workdir /workdir docker.io/pipelinecomponents/markdownlint-cli2:0.12.0@sha256:a3977fba9814f10d33a1d69ae607dc808e7a6470b2ba03e84c17193c0791aac0 /workdir/hack/markdownlint.sh
+ IS_CONTAINER=TRUE
+ CONTAINER_RUNTIME=podman
+ '[' TRUE '!=' false ]
+ markdownlint-cli2 '**/*.md' '#.github'
markdownlint-cli2 v0.14.0 (markdownlint v0.35.0)
Finding: **/*.md !.github
Linting: 4 file(s)
Summary: 0 error(s)

Seems to be ok from my side of things (?)

@dtantsur
Copy link
Member

dtantsur commented Feb 6, 2025

/test markdownlint

@dtantsur
Copy link
Member

dtantsur commented Feb 6, 2025

Was a flake apparently.

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/lgtm

Waiting for the mentioned infra changes before unholding.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@iurygregory iurygregory Awaiting requested review from iurygregory

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable arm64 builds for sushy-tools container
6 participants
@e-minguez @metal3-io-bot @dtantsur @elfosardo @tuminoid @Rozzii